-
Notifications
You must be signed in to change notification settings - Fork 693
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extended Valkey client introspection functionality #668
Comments
Originally reference from redis/redis#12311. |
Nit Title: Extended Client Introspection functionality The default behavior for The downside of introducing the new API is maintaining two set of API(s) and no guarantee of administrator(s) of moving to this. |
Old habits die hard.
I think you raise a really good point. We could add a pagination functionality by doing client-list based off of ID, and add that to client list. I think we have seen that people generally don't migrate to new commands, so it probably makes more sense to enhanced the ones we have. |
@valkey-io/core-team I'm happy to take this issue up if this is an approved change. Please let me know if I can proceed. |
We can abstract the current filtering logic out (and add new filters) and then use it in different commands as required. In my opinion, CLIENT DESCRIBE (if approved) should be taken in a separate PR. |
I feel |
CLIENT KILL has more filters than any other. Let's first add the missing ones of those to CLIENT LIST, to unify them. We can de-duplicate the parsing code too. That's a good PR to start with IMHO. |
Sorry, is there the command CLIENT COUNT? new command? |
I like this idea. In #1398 , I hope we have a |
I would like to summarize the issues that we are going to solve under #668. Please feel free to add any that I have missed.
@valkey-io/core-team are we good to proceed with all the above mentioned issues? I can come with the separate issues for each, so this can be picked up by multiple people. We can even discuss in detail about each of these in their respective issues. |
To me, it seems safe to proceed with 1-3. For 4, I think we should discuss it a bit more first. I don't want to add a new command that almost nobody will use (like CLUSTER SHARDS) so I want to have a good motivation about uses cases and the features (more fields? pagination?), the syntax, etc. |
We want to standardize the way that admin users can describe and interact with the client commands. We are proposing to generalize the filters introduced in CLIENT KILL so that it also works to count and list clients as well.
In the end, we will support the following 4 commands.
The supported filters will be:
In Redis we also discussed adding a new command,
CLIENT DESCRIBE
, will also introduce the notion of selectors. Selectors allow you to scope down the fields you are interested in.The text was updated successfully, but these errors were encountered: