-
Notifications
You must be signed in to change notification settings - Fork 693
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Client Introspection] Client Commands Extended Filtering #1466
Open
sarthakaggarwal97
wants to merge
12
commits into
valkey-io:unstable
Choose a base branch
from
sarthakaggarwal97:client-extended-filters
base: unstable
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[Client Introspection] Client Commands Extended Filtering #1466
sarthakaggarwal97
wants to merge
12
commits into
valkey-io:unstable
from
sarthakaggarwal97:client-extended-filters
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarthakaggarwal97
force-pushed
the
client-extended-filters
branch
from
December 20, 2024 16:36
6819a68
to
c913dcb
Compare
Signed-off-by: Sarthak Aggarwal <[email protected]>
Signed-off-by: Sarthak Aggarwal <[email protected]>
Signed-off-by: Sarthak Aggarwal <[email protected]>
Signed-off-by: Sarthak Aggarwal <[email protected]>
Signed-off-by: Sarthak Aggarwal <[email protected]>
Signed-off-by: Sarthak Aggarwal <[email protected]>
Signed-off-by: Sarthak Aggarwal <[email protected]>
Signed-off-by: Sarthak Aggarwal <[email protected]>
sarthakaggarwal97
force-pushed
the
client-extended-filters
branch
from
December 20, 2024 18:23
c913dcb
to
69b8bc3
Compare
Signed-off-by: Sarthak Aggarwal <[email protected]>
Signed-off-by: Sarthak Aggarwal <[email protected]>
sarthakaggarwal97
force-pushed
the
client-extended-filters
branch
2 times, most recently
from
December 20, 2024 19:49
094ee75
to
e518d93
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## unstable #1466 +/- ##
============================================
- Coverage 70.86% 70.73% -0.14%
============================================
Files 119 119
Lines 64693 64860 +167
============================================
+ Hits 45847 45876 +29
- Misses 18846 18984 +138
|
Signed-off-by: Sarthak Aggarwal <[email protected]>
Signed-off-by: Sarthak Aggarwal <[email protected]>
sarthakaggarwal97
force-pushed
the
client-extended-filters
branch
from
December 20, 2024 21:51
e518d93
to
b5cb71d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, we introduce a support for few more filters for
CLIENT LIST
andCLIENT KILL
commands. We introduce these new filters:pattern the client must subscribe to
channel the client must subscribe to
<shard channel the client must subscribe to>
Client must include this flag. This can be a string with bunch of flags present one after the other.
client name
minimum idle time of the client
Built on top of: #1401
Partly Addresses: #668