Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Client Introspection] Client Commands Extended Filtering #1466

Open
wants to merge 12 commits into
base: unstable
Choose a base branch
from

Conversation

sarthakaggarwal97
Copy link
Contributor

In this PR, we introduce a support for few more filters for CLIENT LIST and CLIENT KILL commands. We introduce these new filters:

  1. PATTERN pattern the client must subscribe to
  2. CHANNEL channel the client must subscribe to
  3. SHARD-CHANNEL <shard channel the client must subscribe to>
  4. FLAGS Client must include this flag. This can be a string with bunch of flags present one after the other.
  5. NAME client name
  6. MIN-IDLE minimum idle time of the client

Built on top of: #1401
Partly Addresses: #668

@sarthakaggarwal97 sarthakaggarwal97 marked this pull request as ready for review December 20, 2024 16:59
Signed-off-by: Sarthak Aggarwal <[email protected]>
Signed-off-by: Sarthak Aggarwal <[email protected]>
@sarthakaggarwal97 sarthakaggarwal97 force-pushed the client-extended-filters branch 2 times, most recently from 094ee75 to e518d93 Compare December 20, 2024 19:49
Copy link

codecov bot commented Dec 20, 2024

Codecov Report

Attention: Patch coverage is 86.32479% with 64 lines in your changes missing coverage. Please review.

Project coverage is 70.73%. Comparing base (b56f4f7) to head (b5cb71d).
Report is 1 commits behind head on unstable.

Files with missing lines Patch % Lines
src/networking.c 86.32% 64 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           unstable    #1466      +/-   ##
============================================
- Coverage     70.86%   70.73%   -0.14%     
============================================
  Files           119      119              
  Lines         64693    64860     +167     
============================================
+ Hits          45847    45876      +29     
- Misses        18846    18984     +138     
Files with missing lines Coverage Δ
src/commands.def 100.00% <ø> (ø)
src/networking.c 87.79% <86.32%> (-0.85%) ⬇️

... and 11 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant