Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a hint about the current file for TCL debugging #1459

Merged
merged 1 commit into from
Dec 19, 2024
Merged

Conversation

madolson
Copy link
Member

There are some tests like https://github.com/valkey-io/valkey/actions/runs/12403569355/job/34627292621 that fail and give no useful information since they are outside of a test context. Now we will at least get the file we are located in.

We can sort of reverse engineer where we are in the test by seeing which tests have finished in a file.

[TIMEOUT]: clients state report follows.
sock6 => (SPAWNED SERVER) pid:30375 - tests/unit/info.tcl
Killing still running Valkey server 30375 - tests/unit/info.tcl

Copy link

codecov bot commented Dec 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.61%. Comparing base (33f42d7) to head (4e2bade).
Report is 66 commits behind head on unstable.

Additional details and impacted files
@@             Coverage Diff              @@
##           unstable    #1459      +/-   ##
============================================
- Coverage     70.76%   70.61%   -0.15%     
============================================
  Files           116      116              
  Lines         63300    63264      -36     
============================================
- Hits          44793    44676     -117     
- Misses        18507    18588      +81     

see 49 files with indirect coverage changes

Copy link
Member

@enjoy-binbin enjoy-binbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great! it is hunting me for a long time.

@enjoy-binbin enjoy-binbin merged commit 079f4ed into unstable Dec 19, 2024
61 of 64 checks passed
@enjoy-binbin enjoy-binbin deleted the test_hint branch December 19, 2024 06:18
enjoy-binbin pushed a commit that referenced this pull request Dec 20, 2024
In #1459, I missed that the data was also used to keep track of the PID
files so if the testing framework crashed it would no longer be able to
cleanup the extra servers. So now we properly extract the PID and store
it so we can clean up PIDs.

Signed-off-by: Madelyn Olson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants