Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove readability refactor for failover auth to fix clang warning #1481

Merged
merged 1 commit into from
Dec 24, 2024

Conversation

madolson
Copy link
Member

As part of #1463, I made a small refactor between the PR and the daily test I submitted to try to improve readability by adding a function to abstract the extraction of the message types. However, that change apparently caused GCC to throw another warning, so reverting the abstraction on just one line.

https://github.com/madolson/valkey/actions/runs/12472455780

@madolson madolson changed the title Remove readability refactor for failover auth Remove readability refactor for failover auth to fix clang warning Dec 24, 2024
Copy link

codecov bot commented Dec 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.82%. Comparing base (d00c856) to head (53c542d).
Report is 1 commits behind head on unstable.

Additional details and impacted files
@@             Coverage Diff              @@
##           unstable    #1481      +/-   ##
============================================
- Coverage     70.86%   70.82%   -0.05%     
============================================
  Files           119      119              
  Lines         64852    64852              
============================================
- Hits          45958    45930      -28     
- Misses        18894    18922      +28     
Files with missing lines Coverage Δ
src/cluster_legacy.c 86.79% <100.00%> (-0.07%) ⬇️

... and 11 files with indirect coverage changes

@enjoy-binbin enjoy-binbin merged commit 2ee06e7 into valkey-io:unstable Dec 24, 2024
50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants