Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for acl selectors with no permissions or patterns #1515

Merged
merged 2 commits into from
Jan 6, 2025

Conversation

madolson
Copy link
Member

@madolson madolson commented Jan 6, 2025

I prefer the assert_blah style since it gives a precise line number instead of the end of the test. The wording was also wrong, %RW~ does something, it gives access to the single empty key, so updated the wording.

Signed-off-by: Madelyn Olson <[email protected]>
Copy link

codecov bot commented Jan 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.85%. Comparing base (c0014ef) to head (bf94455).
Report is 3 commits behind head on unstable.

Additional details and impacted files
@@             Coverage Diff              @@
##           unstable    #1515      +/-   ##
============================================
+ Coverage     70.82%   70.85%   +0.03%     
============================================
  Files           120      120              
  Lines         64911    64914       +3     
============================================
+ Hits          45972    45994      +22     
+ Misses        18939    18920      -19     

see 12 files with indirect coverage changes

@hpatro hpatro changed the title Fix incorrect wording for CVE tests Add tests for acl selectors with no permissions or patterns Jan 6, 2025
@hpatro hpatro merged commit e1db553 into valkey-io:unstable Jan 6, 2025
49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants