add paused_actions for INFO stats #1519
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: zhaozhao.zz <[email protected]>
soloestoy
force-pushed
the
info-client-pause
branch
from
fc28ff0 to
bc2757d
Compare
Signed-off-by: zhaozhao.zz <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## unstable #1519 +/- ##
============================================
+ Coverage 70.83% 70.86% +0.02%
============================================
Files 120 120
Lines 64911 64916 +5
============================================
+ Hits 45982 46000 +18
+ Misses 18929 18916 -13
|
madolson
reviewed
Jan 7, 2025
| @@ -5863,6 +5863,8 @@ sds genValkeyInfoString(dict *section_dict, int all_sections, int everything) { | |||
| server.stat_last_eviction_exceeded_time ? (long long)elapsedUs(server.stat_last_eviction_exceeded_time) : 0; | |||
| long long current_active_defrag_time = | |||
| server.stat_last_active_defrag_time ? (long long)elapsedUs(server.stat_last_active_defrag_time) : 0; | |||
| char *paused_actions = server.paused_actions & PAUSE_ACTION_CLIENT_ALL ? "all" : server.paused_actions & PAUSE_ACTION_CLIENT_WRITE ? "write" | |||
There was a problem hiding this comment.
Paused actions will never return "all" right? If it's all, it won't execute the command running "all". It's fine, but just worth mentioning this will only show write or none.
madolson
approved these changes
Jan 7, 2025
hpatro
reviewed
Jan 8, 2025
| r client unpause | ||
|
|
||
| r multi | ||
| r client PAUSE 1000 All |
There was a problem hiding this comment.
nit pick: I find it weird seeing it in mixed case :| . Could we write it in lower or upper case?
Suggested change
| r client PAUSE 1000 All | |
| r client PAUSE 1000 ALL |
artikell
reviewed
Jan 8, 2025
| @@ -5930,7 +5932,8 @@ sds genValkeyInfoString(dict *section_dict, int all_sections, int everything) { | |||
| "eventloop_duration_sum:%llu\r\n", server.duration_stats[EL_DURATION_TYPE_EL].sum, | |||
| "eventloop_duration_cmd_sum:%llu\r\n", server.duration_stats[EL_DURATION_TYPE_CMD].sum, | |||
| "instantaneous_eventloop_cycles_per_sec:%llu\r\n", getInstantaneousMetric(STATS_METRIC_EL_CYCLE), | |||
| "instantaneous_eventloop_duration_usec:%llu\r\n", getInstantaneousMetric(STATS_METRIC_EL_DURATION))); | |||
| "instantaneous_eventloop_duration_usec:%llu\r\n", getInstantaneousMetric(STATS_METRIC_EL_DURATION), | |||
| "paused_actions:%s\r\n", paused_actions)); | |||
There was a problem hiding this comment.
The end time of the paused action is also a key information. Is this considered for inclusion?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
paused_actionsfor INFO stats to inform users about the instance's running status.