fix isVhdDifferencing id

@xen-orchestra/backups/_cleanVm.mjs

@@ -569,39 +569,19 @@ export async function cleanVm(
     // systematically update size and differentials after a merge
 
     // @todo : after 2024-04-01 remove the fixmetadata options since the size computation is fixed
-    console.log({mergedSize, fixMetadata, fileSystemSize, size})
+    console.log({/* metadata, */ /* snapshot_time: metadata.vdis, */ vdis: metadata.vdis, isVhdDifferencing: metadata.isVhdDifferencing, parent: metadata.vmSnapshot.parent, mergedSize, fixMetadata, fileSystemSize, size})
     if (mergedSize || (fixMetadata && fileSystemSize !== size)) {
       metadata.size = mergedSize ?? fileSystemSize ?? size
 
       if (mergedSize) {
-        // Dynamically rebuild the isVhdDifferencing metadata
+        // all disks are now key disk
         metadata.isVhdDifferencing = {}
 
-        const vdiChains = {} // Map of VDI IDs to their chain of VHDs
-
-        // Build VDI chains from metadata
-        for (const id of Object.values(metadata.vdis ?? {})) {
-          const vhdPath = `${id}.vhd`
-
-          // Check if this VHD has a parent
-          const parent = metadata.parent?.[vhdPath]
-          if (parent) {
-            vdiChains[id] = vdiChains[id] || []
-            vdiChains[id].push({ vhd: vhdPath, isDifferencing: true })
-          } else {
-            // No parent means it's a key disk
-            vdiChains[id] = [{ vhd: vhdPath, isDifferencing: false }]
-          }
-        }
-
-        // Update the metadata for isVhdDifferencing
-        for (const chain of Object.values(vdiChains)) {
-          for (const { vhd, isDifferencing } of chain) {
-            metadata.isVhdDifferencing[vhd] = isDifferencing
-          }
+        for (const id of Object.keys(metadata.vdis ?? {})) {
+          console.log({id})
+          metadata.isVhdDifferencing[`${id}.vhd`] = false
         }
       }
-
       mustRegenerateCache = true
       try {
         await handler.writeFile(metadataPath, JSON.stringify(metadata), { flags: 'w' })