Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(xo-lite): add host network tab and pif table / status component … #8180

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

J0ris-K
Copy link
Contributor

@J0ris-K J0ris-K commented Dec 6, 2024

Description

add host network tab and pif table / status component and pif store

Screenshot

image

Checklist

  • Commit
    • Title follows commit conventions
    • Reference the relevant issue (Fixes #007, See xoa-support#42, See https://...)
    • If bug fix, add Introduced by
  • Changelog
    • If visible by XOA users, add changelog entry
    • Update "Packages to release" in CHANGELOG.unreleased.md
  • PR
    • If UI changes, add screenshots
    • If not finished or not tested, open as Draft

Review process

This 2-passes review process aims to:

  • develop skills of junior reviewers
  • limit the workload for senior reviewers
  • limit the number of unnecessary changes by the author
  1. The author creates a PR.
  2. Review process:
    1. The author assigns the junior reviewer.
    2. The junior reviewer conducts their review:
      • Resolves their comments if they are addressed.
      • Adds comments if necessary or approves the PR.
    3. The junior reviewer assigns the senior reviewer.
    4. The senior reviewer conducts their review:
      • If there are no unresolved comments on the PR → merge.
      • Otherwise, we continue with 3.
  3. The author responds to comments and/or makes corrections, and we go back to 2.

Notes:

  1. The author can request a review at any time, even if the PR is still a Draft.
  2. In theory, there should not be more than one reviewer at a time.
  3. The author should not make any changes:
    • When a reviewer is assigned.
    • Between the junior and senior reviews.

@J0ris-K J0ris-K added the XO Lite label Dec 6, 2024
@J0ris-K J0ris-K requested a review from OlivierFL December 6, 2024 16:43
@J0ris-K J0ris-K self-assigned this Dec 6, 2024
@J0ris-K J0ris-K removed the request for review from OlivierFL December 6, 2024 16:47
@J0ris-K J0ris-K marked this pull request as draft December 6, 2024 16:49
@J0ris-K J0ris-K requested a review from OlivierFL December 6, 2024 16:49
@J0ris-K J0ris-K force-pushed the lite/host-network-tab branch 3 times, most recently from 8406813 to a0ba86d Compare December 12, 2024 13:17
@J0ris-K J0ris-K marked this pull request as ready for review December 12, 2024 13:20
@J0ris-K J0ris-K force-pushed the lite/host-network-tab branch 2 times, most recently from 9ddb152 to 2e181e3 Compare December 12, 2024 20:30
@J0ris-K J0ris-K requested review from ByScripts and removed request for OlivierFL December 12, 2024 21:13
Comment on lines +30 to +35
const status = computed(() => {
if (pifStatus) {
return 'connected'
}
return 'disconnected'
})
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
const status = computed(() => {
if (pifStatus) {
return 'connected'
}
return 'disconnected'
})
const status = computed(() => (pifStatus ? 'connected' : 'disconnected'))

import { useI18n } from 'vue-i18n'

const { pifStatus, card } = defineProps<{
pifStatus: any
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Avoid using any

return 'disconnected'
})

const getStatusProps = (status: Status) => states.value[status]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand this function.

Looking at the template, we can see it only receives the status computed property, so it could be a computed property itself:

Suggested change
const getStatusProps = (status: Status) => states.value[status]
const statusProps = computed(() => states.value[status.value])

However, the status computed property only returns either 'connected' or 'disconnected', while the states object contains three properties: 'connected', 'disconnected', and 'partial'.

This means the 'partial' property appears to never be used.

Furthermore, we can see that the status computed property is only used within the statusProps computed property. This creates redundancy, suggesting that all this logic could likely be simplified by combining it into a single computed property.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, sure

@J0ris-K J0ris-K force-pushed the lite/host-network-tab branch from 2e181e3 to 98b38d2 Compare December 30, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants