Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Pokemon series is a bit messy #29

Open
Die4Ever opened this issue Jul 29, 2024 · 3 comments
Open

[Feature]: Pokemon series is a bit messy #29

Die4Ever opened this issue Jul 29, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@Die4Ever
Copy link
Member

Die4Ever commented Jul 29, 2024

Summary

The original site looked like this

Screenshot_20240729-033952

Split by sub-series instead of by game.

Maybe we could divide series by sub-series, and then also have randomizers with more than 5 supported games listed outside of the games and have their games listed inside the randomizer itself (like the recent updates section does). Or maybe we could do more sub-series for Pokemon, like Core GB, Core GBA, Core DS... And have the randomizers listed in each of the sub-series they apply to.

Maybe each series could have a field to specify how it is formatted? Like multi-series already has its own format but that's hardcoded, it could be a flag in the yml file.

@Die4Ever Die4Ever added the enhancement New feature or request label Jul 29, 2024
@Die4Ever Die4Ever pinned this issue Jul 29, 2024
@Die4Ever
Copy link
Member Author

Die4Ever commented Aug 1, 2024

what do we think of this style of grouping, separating out multi-game randomizers?

image

@Die4Ever
Copy link
Member Author

Die4Ever commented Aug 1, 2024

it can look a little silly when there's only 1 non-multi-game randomizer

image

and then if we also want to do grouping by sub-series, it could become a bit complicated, or maybe users will get confused with the variations of formatting (grouped by game, grouped by sub-series, grouped by game and sub-series, multi-games together, ungrouped)

This also means if a game is only represented by multi-game randomizers, then the tags for the game are not displayed (release year, platforms, genres, sub-series)

@SmashManiac
Copy link
Member

This hybrid approach is fine in my opinion as it cleans up some duplicate data a bit compared to now, but I agree with the flagged issues so far, and it would effectively revert to grouping by rando as I was originally doing instead of by game, with all that entails.

One thing I would consider instead is to use the <details> and <summary> HTML elements to collapse the information per game by default. For Pokémon specifically, we could also potentially classify each Gen if things would get out of control otherwise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants