Multi-game randos displayed separately #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
SmashManiac
approved these changes
Aug 2, 2024
There was a problem hiding this comment.
Approving, but you may want to consider the caveats discussed in #29 (comment) before merging.
Wouldn't collapsing all the games just be annoying to browse? And it causes issues with ctrl+f (although most people would search for game titles not rando titles) |
|
To clarify, I meant collapsing per game title. If someone already knows the rando's name, they would use a search engine anyway. However, doing so wouldn't be possible with this pull request, hence my reservations. It really depends on how we want to move forward, and I don't want to impose anything here, so either way is fine by me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Pull the multi-game randomizers out of the game groups so that they don't get displayed so many times. Based on #31 so if you merge this one you don't need to review that one.
partially helps #29 (pokemon needs fixes in its yml file too)
If we also want to do grouping by sub-series, it could become a bit complicated, or maybe users will get confused with the variations of formatting (grouped by game, grouped by sub-series, grouped by game and sub-series, multi-games together, ungrouped)
This also means if a game is only represented by multi-game randomizers, then the tags for the game are not displayed (release year, platforms, genres, sub-series)