Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sitting, clapping, and salute emote actions. #137

Merged
merged 42 commits into from
Feb 26, 2023
Merged

Conversation

Gigabyte5671
Copy link
Member

@Gigabyte5671 Gigabyte5671 commented Feb 13, 2023

  • Sitting action (default keybind G) snaps to nearby applicable objects (with animate_ at the start of their mesh names). This action has multiple variations:

    • Chair:
      image
    • Beanbag:
      image
    • Ground:
      image
      (This action is extensible, any animation can be played by including the animation's name in the name of the snap object).
  • Clapping emote (default keybind H).
    image

  • Salute emote (default keybind J).
    image

  • Show icons (nametags) above interactable objects:
    image

This PR also adds a button to the Help menu, allowing the player to reset their settings:
image

@Gigabyte5671 Gigabyte5671 added the enhancement New feature or request label Feb 13, 2023
@Gigabyte5671
Copy link
Member Author

Gigabyte5671 commented Feb 16, 2023

A few more changes need to be made before this PR is ready:

@Gigabyte5671
Copy link
Member Author

Note: Updated the build_test workflow with a workaround for a recent breaking change in Node 17. References: [1], [2], [3].

@Gigabyte5671
Copy link
Member Author

@digisomni I've created issues #140, #141, #142, and #143 to track bugs related to this feature.

The merge conflicts need to be resolved whilst merging the PR. Attempting to resolve before merge will break either this build or master. Lmk when you would like to merge this and I can resolve the conflict 👍.

@Gigabyte5671 Gigabyte5671 merged commit 4be1750 into master Feb 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant