-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sitting, clapping, and salute emote actions. #137
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- `Shift-M` is superseded by the reload button in the Avatar overlay. - Toggling gravity can now be done with fly-mode (default `F`) instead of `G`.
Adjust the avatar's walking speed to better match the walk animation.
Adjust the speed of fast ascent in fly mode to better match the fast X-Z speed.
Accessible from the Help menu in the toolbar.
Move all nametag methods from VScene into their own entity class.
A few more changes need to be made before this PR is ready:
|
Use the NametagEntity's existing `registerBeforeRender` call, instead of multiple Store watchers. Change the NametagEntity's visibility, instead of disposing and re-generating the mesh.
- Increase the FOV from 80 to 85. - Enable Bloom.
Signed-off-by: Giga <[email protected]>
This was referenced Feb 26, 2023
@digisomni I've created issues #140, #141, #142, and #143 to track bugs related to this feature. The merge conflicts need to be resolved whilst merging the PR. Attempting to resolve before merge will break either this build or master. Lmk when you would like to merge this and I can resolve the conflict 👍. |
Signed-off-by: Giga <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sitting action (default keybind
G
) snaps to nearby applicable objects (withanimate_
at the start of their mesh names). This action has multiple variations:(This action is extensible, any animation can be played by including the animation's name in the name of the snap object).
Clapping emote (default keybind
H
).Salute emote (default keybind
J
).Show icons (nametags) above interactable objects:
This PR also adds a button to the Help menu, allowing the player to reset their settings: