fix(playground) app shouldn’t crash while user is typing

[chrisgervang]

Background

The playground currently crashes as the user is typing. For example, an empty object, like layers: [ { } ], will be parsed as a plain object and passed to deck, which, of course will throw an error.

Change List

• post process json props to filter out invalid objects

[coveralls]

coverage: 91.703%. remained the same
when pulling dc45214 on chrisgervang-patch-1
into 06f80f1 on master.

[felixpalmer]

Have you tested if this still works after minification? Ie running ‘yarn build-staging’ rather than ‘yarn start’ in website ?

[ibgreen]

There are several ways to address this.
Perhaps we could make deck more resilient and not fail on one bad component...

[chrisgervang]

True. I figured it was for a bit of perf gains, and to keep things simpler. It could be argued that only something like this json module would need validation since here the end user is hooking into props directly whereas most apps have some abstraction in-between.

On the flip side, validation can be this simple.

[ibgreen]

Have you tested if this still works after minification? Ie running ‘yarn build-staging’ rather than ‘yarn start’ in website ?

Is it the check for widget.onAdd you are looking at? I see your point but I have never seen method names being minified (just global symbols), would actually be a pleasant surprise to me if they were.