Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert added type declarations from #8945 #9318

Merged
merged 4 commits into from
Dec 23, 2024
Merged

Revert added type declarations from #8945 #9318

merged 4 commits into from
Dec 23, 2024

Conversation

chrisgervang
Copy link
Collaborator

@chrisgervang chrisgervang commented Dec 22, 2024 •
edited
Loading

Background

Reverts some of #8945

Change List

  • remove typed

@chrisgervang chrisgervang requested a review from ibgreen December 22, 2024 19:11
@chrisgervang chrisgervang mentioned this pull request Dec 22, 2024
Merged
1 task
ibgreen
ibgreen approved these changes Dec 23, 2024
View reviewed changes
Copy link
Collaborator

@ibgreen ibgreen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for helping fix my mistake!

@chrisgervang chrisgervang merged commit 06f80f1 into master Dec 23, 2024
2 checks passed
@chrisgervang chrisgervang deleted the chr/revert-typed branch December 23, 2024 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ibgreen ibgreen ibgreen approved these changes

@felixpalmer felixpalmer Awaiting requested review from felixpalmer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chrisgervang @ibgreen