Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[http-client] Ignore case-sensitivity while matching header names #5642

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

uarlouski
Copy link
Member

@uarlouski uarlouski commented Jan 6, 2025

Spec:

  • HTTP1.X - headers are case insensitive
  • HTTP2.X - headers are in lower case

@uarlouski uarlouski requested a review from a team as a code owner January 6, 2025 08:17
Copy link

github-actions bot commented Jan 6, 2025

Qodana for JVM

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at [email protected]

Copy link

codecov bot commented Jan 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.70%. Comparing base (bed746c) to head (660ad0f).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##             master    #5642    +/-   ##
==========================================
  Coverage     97.69%   97.70%            
+ Complexity     7378     7135   -243     
==========================================
  Files           989      989            
  Lines         20685    20685            
  Branches       1353     1353            
==========================================
+ Hits          20209    20211     +2     
+ Misses          364      363     -1     
+ Partials        112      111     -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@valfirst valfirst merged commit 7f092b8 into master Jan 6, 2025
11 checks passed
@valfirst valfirst deleted the feature/header-case-insensitive-match branch January 6, 2025 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants