-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vdoctor: fix format, windows, tcc #23361
Conversation
Co-authored-by: JalonSolov <[email protected]>
Co-authored-by: JalonSolov <[email protected]>
Co-authored-by: JalonSolov <[email protected]>
Co-authored-by: JalonSolov <[email protected]>
Co-authored-by: JalonSolov <[email protected]>
Please also update the first comment here if you change the output, so people can see up front what they'll be getting. :-) |
cmd/tools/vdoctor.v
Outdated
a.line('CC version', a.cmd(command: 'cc --version')) | ||
a.line('emcc version', a.cmd(command: 'emcc --version')) | ||
a.line('GCC version', a.cmd(command: 'gcc --version')) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no need to capitalize GCC
. Leave it as just gcc version
like the rest for consistency.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, remove emcc
detection...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, emcc
detection should stay.
It is useful for diagnosing problems when you want to compile games to wasm through:
v -os wasm32_emscripten examples/2048/
If that does not work, a report, including the output of v doctor
can help pinpoint the problem.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My comment before that was only about the capitalization of GCC
, perhaps that was misleading, sorry. I did not meant to approve the removal of emcc - I thought it is just moved/reordered.
Excellent work overall. The new look is much cleaner and easier and faster to scan at a glance. |
This PR will
tcc -v
to output;gcc
,clang
,glibc
version detect;msvc
version detect under Windows;emcc
detection;New
v doctor
will output:By copy this
vdoctor
output togithub
, you will get a nice lookingmarkdown
format:Linux:
测
,试
], value: /home/mars/v/测试/dir contains spacesWindows :
测
,试
], value: D:\测试tmp\v test dir contain space