Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not yield DRIVER_OBJECT instances found in scanning that are not a… #1488

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

atcuno
Copy link
Contributor

@atcuno atcuno commented Dec 28, 2024

…ctual instances #1481

@ikelos ikelos linked an issue Dec 30, 2024 that may be closed by this pull request
Copy link
Member

@ikelos ikelos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Never seen a variable just accessed without an assignment or anything, but if it works? Just want to check that getting back a structure with only one of those is still worthwhile...

# of interest to plugins, so if it is not accessible then this instance
# is not useful or usable during analysis
try:
mem_object.DriverStart
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is just listing a variable enough to trip the output? I'd think that could get optimized out? Also, don't we care if the whole structure is valid, or would having just DriverStart be enough?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MajorFunction access crashes driverirp
2 participants