refactor: middleware as atomic files + docs #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
so middleware stays maintainable when adding more (like the upcoming file proxy middleware) and has a structure suitable to add tests/ to.
5 tasks
Deploying head-start with
|
| Latest commit: |
9137a28
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://da72b2f5.head-start.pages.dev |
| Branch Preview URL: | https://refactor-middleware-atomic-f.head-start.pages.dev |
jbmoelker
commented
Jan 5, 2025
| @@ -2,6 +2,10 @@ | |||
|
|
|||
| **Head Start leverages [Astro file-based routing](https://docs.astro.build/en/core-concepts/routing/#_top) combined with Cloudflare features for redirects and page not found behaviour. The setup is enhanced with i18n routing, API routing, nested page routing and helpers to resolve routes.** | |||
|
|
|||
| ## Routing middleware | |||
There was a problem hiding this comment.
Should we also add middleware/ to project-structure.md?
jurgenbelien
approved these changes
Jan 6, 2025
There was a problem hiding this comment.
Looks good, mentioned @sjoerdbeentjes for adding a caveat do the docs, but I feel it is not strictly necessary.
| import { preview } from './preview'; | ||
| import { redirects } from './redirects'; | ||
|
|
||
|
|
| @@ -0,0 +1,3 @@ | |||
| # Middleware | |||
|
|
|||
| **[Astro supports middleware](https://docs.astro.build/en/guides/middleware/) that allows you to intercept requests and responses and inject behaviors dynamically every time a page or endpoint is about to be rendered.** | |||
There was a problem hiding this comment.
@sjoerdbeentjes you recently mentioned the caveat that when home resolves as a static file, middleware will not run. Perhaps it is wise to explicitly add this here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
l# Changes
Refactors middleware to atomic files (
src/middleware/...), so middleware stays maintainable when adding more (like the upcoming file proxy middleware) and has a structure suitable to add tests to (insrc/middleware/tests/like done insrc/lib/datocms/tests/).Associated issue
N/A
How to test
i18n,redirects) still work (previewcan't be tested on deploy preview, unless we list it as a preview branch;datocmsis hard to check on deploy preview)datocms,i18n,preview,redirects) still workChecklist
I have added a decision log entry if the change affects the architecture or changes a significant technology