fix: display of bank invoice information

[gaboulsvtex]

What is the purpose of this pull request?

Fix a bug.

What problem is this solving?

In orders where the bank invoice payment method wasn't the first payment of the first transaction, its information wasn't displayed at the order placed page

How should this be manually tested?

There are 2 use cases for this change:

• Orders with a single transaction with multiple payments, in which the one of them is a bank invoice and it isn't in the first position of the payments array;
• Orders with multiple transactions in which one of them has a bank invoice payment, and this transaction isn't the first of the array.

Screenshots or example usage

Example of an order with bank invoice in the second payment of the array, where its information is not displayed:
https://gaboulstore.myvtex.com/checkout/orderPlaced/?og=1486610500025

Example of the same order, but in a workspace with this change implemented:
https://bankinvoice--gaboulstore.myvtex.com/checkout/orderPlaced/?og=1486610500025

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• Requires change to documentation, which has been updated accordingly.

[vtex-io-ci-cd]

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

• Patch (backwards-compatible bug fixes)

• Minor (backwards-compatible functionality)

• Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

• No thanks, I would rather do it manually 😞

[vtex-io-docs-bot]

Beep boop 🤖

I noticed you didn't make any changes at the docs/ folder

• There's nothing new to document 🤔
• I'll do it later 😞

In order to keep track, I'll create an issue if you decide now is not a good time

• I just updated 🎉🎉

[iago1501]

Algumas alterações rápidas de boas práticas/legibilidade, depois de verificado se ainda resolve o problema, vou validar de fato a usabilidade da alteração pra ver o impacto que ela vai ter

[gaboulsvtex]

Obrigado pelas sugestões.
Em meu novo commit eu fiz apenas alguns ajustes em cima da sua sugestão:

• Removi os nested ternaries da linha 69;
• Corrigi a função sortPayments(), que estava invertida e o TypeScript não aceitou a operação aritmética entre booleanos.

[iago1501]

@gaboulsvtex , eu fiz uma outra proposta de implementação, dado que a ideia de reordenar só seria um workaround pro problema principal (retornar apenas um método de pagamento quando possui vários), se puder checar pra ver se resolve o seu problema, creio que resolvendo, a gente encerra esse e segue pelo outro: #200