added condition for checkbox #3
Conversation
|
Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖 Please select which version do you want to release:
And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.
|
|
Beep boop 🤖 I noticed you're not using the Docs Builder properly yet, if you need help to set that up please go to IO Documentation |
|
@klzns would you mind taking a look over this when you've got the time? Thanks! |
Klynger
requested review from
santosluiz000,
victorhmp,
vitorflg,
kaisermann and
klzns
Co-authored-by: Breno Calazans <[email protected]>
| @@ -68,11 +69,18 @@ const ProductSelector = ({ showToast, intl }: Props) => { | |||
| } | |||
| } | |||
|
|
|||
| const categoryArrayLength = valuesFromContext?.product?.categories.length; | |||
| const categoryAvailable = categoryArrayLength === 1 ? valuesFromContext?.product?.categories[0] : valuesFromContext?.product?.categories[categoryArrayLength - 2] | |||
There was a problem hiding this comment.
why are you choosing this particular category?
|
I am not sure that it is a good experience for the buyer having the checkbox disabled for no explained reason. I will check with @rsimoens what we could do to communicate it clearer. |
|
I would like to know more about the motivation of this condition. At first, I think this kind of limitation may not be necessary at all, and might lead to reduce store conversion if not configured right. E.g.: comparing DSLR cameras with Mirrorless cameras is important in the decision making process and, depending on how the store's categories are organised, with this condition it would not be possible. From my point of view, the risk of users selecting products to compare with no mutual specification fields is not worth this new condition complexity on buyer's experience and store configuration. Besides that, I agree with @alessandrasa, without proper feedback it would be hard for users to understand why they can't select some products to compare depending on how the store organised the category tree. |
|
As example, on these sites I'm able as a buyer to compare products from completely different categories: https://www.bestbuy.com/site/compare?skus=5044601,5712431 Buyers may using the comparison feature with different intents, and this condition might get in their way to make a purchase. |
Added a condition for the checkbox based on the category of the first selected for comparison product
Update: Added some CSS handles