fix(language-core): generate codes for :key prop on v-for and v-if node
#4544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
so1ve
changed the title
:key prop on <template v-if> node:key prop on f-for and v-if node
so1ve
changed the title
:key prop on f-for and v-if node:key prop on v-for and v-if node
|
I temporarily changed the issue to a draft because we should wait for vuejs/core#11322 to be fixed by the upstream. Forcibly handling unrecognized props in language tools will make the code we need to maintain too complex. |
johnsoncodehk
force-pushed
the
master
branch
4 times, most recently
from
c3e80dc to
209717c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I created a fake component to generate codes since
IF_BRANCHnodes are not valid elements. Not sure if it is the best approach.fixes #4539