Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add steps to implement presentationConnection.reconnect(). #323

Merged
merged 2 commits into from
Oct 12, 2023

Conversation

markafoltz
Copy link
Contributor

@markafoltz markafoltz commented Oct 11, 2023

Addresses Issue w3c/presentation-api#471, to fill in how OSP would implement PresentationConnection.reconnect().


Preview | Diff

@markafoltz markafoltz requested a review from tidoust October 11, 2023 23:48
@markafoltz
Copy link
Contributor Author

@tidoust do you mind doing another PR review? :-)

Copy link
Member

@tidoust tidoust left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with nit to make wording consistent with the other paragraphs in that section.

index.bs Outdated Show resolved Hide resolved
Co-authored-by: François Daoust <[email protected]>
@markafoltz markafoltz merged commit 4b54b34 into main Oct 12, 2023
1 check passed
@markafoltz markafoltz deleted the issue-471-reconnect branch October 12, 2023 17:00
github-actions bot added a commit that referenced this pull request Oct 12, 2023
SHA: 4b54b34
Reason: push, by mfoltzgoogle

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants