Add a task queue for scheduling tasks. #115
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
foolip
reviewed
Sep 22, 2021
foolip
reviewed
Sep 23, 2021
| @@ -627,7 +633,7 @@ To <dfn>handle an incoming message</dfn> given a [=WebSocket connection=] | |||
|
|
|||
| 1. Let |method| be |matched|["<code>method</code>"] | |||
|
|
|||
| 1. Run the following steps in parallel: | |||
| 1. [=Queue a WebDriver task=] to run the following: | |||
There was a problem hiding this comment.
Suggested change
| 1. [=Queue a WebDriver task=] to run the following: | |
| 1. [=Queue a WebDriver task=] to run the following steps: |
index.bs
Outdated
|
|
||
| 1. Let |related browsing contexts| be a set containing |context|. |
|
This will be pretty easy to review and quick to land, but the order of landing multiple big conflicting PRs is a bit unclear. @jgraham can you pick an order and ping me when it's time for this one? |
This adds a parallel task queue and uses it to schedule all events, rather than using "in parallel" a lot. This makes it easier to reason about the ordering of events. In addition it makes all events happens as part of a task. This seems likely to match implementations where events will presumably be triggered from event listeners rather than synchronously as in the spec at present. It also means that we don't need the event suppression hack to ensure that navigation commands return before related events are emitted.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preview | Diff