Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing steps and fields in "report an error" in log module. #838

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix missing steps and fields in "report an error" in log module. #838

wants to merge 1 commit into from

Conversation

lauromoura
Copy link

@lauromoura lauromoura commented Dec 20, 2024 •
edited by pr-preview bot
Loading

Missing steps common to the regular console steps, also in the log module:

  • Creating the timestamp field.
  • Creating body from entry.

Also, the stack value was created in its own step, but was not listed in the list of fields creating the specific log.JavascriptLogEntry production.

Preview | Diff

@lauromoura
Fix missing steps and fields in "report an error" in log module.
507c51a 
Missing steps common to the regular console events:

- Creating the `timestamp` field.
- Creating `body` from `entry`.

Also, the `stack` value was created in its own step, but was not
listed in the list of fields creating the specific
`log.JavascriptLogEntry` production.
@lauromoura
Copy link
Author

lauromoura commented Dec 20, 2024 •
edited
Loading

Just connected my W3C account to my GitHub one, but validation is still failing. Does it take some time to work?

Or is this small enough to be marked as non-substantive?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OrKoN OrKoN OrKoN approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lauromoura @OrKoN