Feature/#37 #50
Open
Feature/#37 #50
+108
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gyusang
reviewed
Jan 8, 2021
| if request.method == 'POST': | ||
| tag_name = request.data.get('tag_name') | ||
| if tag_name is None or '': |
There was a problem hiding this comment.
이 구문은 (tag_name is None) or '' 으로 tag_name이 None인 경우에 통과되고, 이외의 경우에는 if ''의 의미가 되어 blank를 구별할 수 없습니다.
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
태그 기능을 일단 만들어두었습니다.