Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default to natural symmetric rendering for the directwrite backend #14

Merged
merged 3 commits into from
Dec 27, 2024
Merged

Default to natural symmetric rendering for the directwrite backend #14

merged 3 commits into from
Dec 27, 2024

Conversation

alokedesai
Copy link
Member

@alokedesai alokedesai commented Dec 26, 2024 •
edited
Loading

  • Font-kit uses the DWRITE_RENDERING_MODE_NATURAL rendering mode when rasterizing with the directwrite backend
  • However, most apps tend to use DWRITE_RENDERING_MODE_NATURAL_SYMMETRIC, which results in text that is better aliased.

See screenshot below to see an example of using DWRITE_RENDERING_MODE_NATURAL (right) vs DWRITE_RENDERING_MODE_NATURAL_SYMMETRIC (left)

image

@alokedesai alokedesai requested a review from acarl005 December 26, 2024 18:39
acarl005
acarl005 approved these changes Dec 26, 2024
View reviewed changes
Copy link

@acarl005 acarl005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

omg yes!

@alokedesai alokedesai merged commit 8c35630 into warp Dec 27, 2024
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acarl005 acarl005 acarl005 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alokedesai @acarl005