Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch error event when multicastdns emit some error #49

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

feichao
Copy link

@feichao feichao commented Jun 22, 2018

Used in Electron, there is no way to catch some internal multicastdns error, when some error occurs, the main thread is crashed. This PR adds a default error callback when user not provide.

@okdistribute
Copy link

this would be nice! @watson

@okdistribute
Copy link

okdistribute commented Jan 10, 2019

This issue is caused by service emitting an error before any error handler can be attached to it: https://github.com/watson/bonjour/blob/master/lib/registry.js#L21

Another way to fix this is to not emit from the service, but from bonjour

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants