Timeouts in operations with sockets #417
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
aritosteles
requested review from
TomasTurina,
jr0me,
sdvendramini and
Nicogp
aritosteles
force-pushed
the
enhancement/157-improve-error-handling
branch
4 times, most recently
from
30f920d to
83e4230
Compare
TomasTurina
reviewed
Dec 13, 2024
TomasTurina
reviewed
Dec 13, 2024
TomasTurina
reviewed
Dec 13, 2024
aritosteles
force-pushed
the
enhancement/157-improve-error-handling
branch
9 times, most recently
from
615308d to
cecad10
Compare
aritosteles
requested review from
TomasTurina
and removed request for
sdvendramini
jr0me
force-pushed
the
enhancement/157-improve-error-handling
branch
2 times, most recently
from
438b259 to
3ef1267
Compare
aritosteles
force-pushed
the
enhancement/157-improve-error-handling
branch
from
3ef1267 to
c479ce0
Compare
jr0me
reviewed
Dec 19, 2024
There was a problem hiding this comment.
I noted a few minor things to look at. I do have some doubts about passing an io_context as a parameter to methods of a class that already received one in their constructors, we should find a way to improve this. Also, if the timeout is not configurable, I would take it out from the parameters list of each method or at least, since it is always the same value, to add it as a constructor parameter or with a set method so we don't need to repeat it so much (at the moment I cannot think of a case where we want to call each method with different timeouts).
aritosteles
force-pushed
the
enhancement/157-improve-error-handling
branch
2 times, most recently
from
a7b2840 to
99e5f33
Compare
TomasTurina
reviewed
Dec 26, 2024
TomasTurina
reviewed
Dec 26, 2024
aritosteles
force-pushed
the
enhancement/157-improve-error-handling
branch
3 times, most recently
from
a790555 to
240667e
Compare
TomasTurina
reviewed
Dec 27, 2024
TomasTurina
reviewed
Dec 27, 2024
aritosteles
force-pushed
the
enhancement/157-improve-error-handling
branch
4 times, most recently
from
7b54435 to
4338db6
Compare
TomasTurina
approved these changes
Dec 27, 2024
- Modifies HttpSocket class - Modifies HttpsSocket class AsyncConnect() AsyncWrite() AsyncRead() Adds helper functions to http_client_utils.hpp and cpp since they will be shared by both sockets.
Add endpoint to logs Set timeout logs to Debug
aritosteles
force-pushed
the
enhancement/157-improve-error-handling
branch
from
4338db6 to
bc2cbee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds timeouts to socket operations that can block the process/co_routine indefinitely.