Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make files download async #472

Merged
merged 6 commits into from
Dec 31, 2024
Merged

Make files download async #472

merged 6 commits into from
Dec 31, 2024

Conversation

TomasTurina
Copy link
Member

@TomasTurina TomasTurina commented Dec 31, 2024

Related issue
#157

Description

This PR introduces the necessary changes to make the files download request asynchronous.

Besides, unnecessary functions PerformHttpRequestDownload and ReadToFile are deleted.

Tests

  • Compilation without warnings in every supported platform
    • Linux
    • Windows
    • MAC OS X

@TomasTurina TomasTurina self-assigned this Dec 31, 2024
@TomasTurina TomasTurina linked an issue Dec 31, 2024 that may be closed by this pull request
4 tasks
@TomasTurina TomasTurina force-pushed the fix/make-download-async branch from 6d6e26b to 841e1dd Compare December 31, 2024 16:00
Copy link
Member

@jr0me jr0me left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@aritosteles aritosteles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@TomasTurina TomasTurina merged commit 95b9665 into master Dec 31, 2024
5 checks passed
@TomasTurina TomasTurina deleted the fix/make-download-async branch December 31, 2024 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve error handling in network functions
3 participants