Select revert back to main AWP #34
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WE2-649 Signed-off-by: Raul Metsma <[email protected]>
mrts
reviewed
Sep 13, 2022
| @@ -32,13 +32,31 @@ namespace | |||
| const byte_vector::value_type PIN_PADDING_CHAR = 0xFF; | |||
| const byte_vector::value_type AUTH_PIN_REFERENCE = 0x01; | |||
|
|
|||
| template <typename F> | |||
| struct ScopeExit | |||
There was a problem hiding this comment.
We already have a scope guard implementation here: https://github.com/web-eid/libelectronic-id/blob/main/src/electronic-ids/pkcs11/PKCS11CardManager.hpp#L52-L54. Can we find a DRY solution that can be used in both places?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WE2-649
Signed-off-by: Raul Metsma [email protected]