Refact native application connection closing #74
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The way the NativeAppService worked before
await nextMessage(...)
It was implemented this way, because initially there was an idea that we could get the signing certificate and request signing in the same native app instance. For various reasons, we decided it was better to start a new native app instance in such a case.
In the current code base, the
background/actions
don't support such a case anymore.There was also a bug with the Edge browser which got a temporary fix in #67, however this should no longer be necessary.
The way the NativeAppService works now
await nextMessage(...)
await nextMessage(...)
The
nextMessage
now has athrowAfterTimeout: Error
argument and thebackground\actions
no longer handle the timeout logic on their own. This way, when the timeout occurs, thenextMessage(...)
can run it's cleanup logic.