Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore major version updates for "node-fetch" #164

Merged
merged 3 commits into from
Apr 27, 2023
Merged

Conversation

miketaylr
Copy link
Member

We don't have sufficient test coverage to know if version 3 is a safe upgrade, so it would be nice to make the bot less noisy.

We don't have sufficient test coverage to know if version 3 is
a safe upgrade, so it would be nice to make the bot less noisy.
@miketaylr miketaylr requested a review from foolip April 4, 2023 23:01
@gsnedders
Copy link
Member

c.f. #165 for getting more confidence

.github/dependabot.yml Outdated Show resolved Hide resolved
@miketaylr
Copy link
Member Author

@gsnedders do you think we shouldn't merge this in the meantime?

@miketaylr miketaylr requested a review from gsnedders April 25, 2023 15:28
Copy link
Member

@gsnedders gsnedders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, no, I didn't mean that, I just don't really understand dependabot to be a great reviewer here 🙃

@foolip foolip merged commit 89df73c into main Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants