Skip to content

Commit

Permalink
Address review feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
past committed Nov 6, 2024
1 parent ca5d139 commit 604b242
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@ RUN chmod a+rx $HOME && useradd --uid 9999 --user-group --create-home browser

# Add apt repositories for Java, Node.js and Google Cloud CLI
RUN export DISTRO_CODENAME=$(awk -F= '/^VERSION_CODENAME/{print$2}' /etc/os-release) && \
echo "deb [signed-by=/usr/share/keyrings/correto.gpg] https://apt.corretto.aws stable main" > /etc/apt/sources.list.d/adoptium.list && \
curl -s https://apt.corretto.aws/corretto.key | gpg --dearmor -o /usr/share/keyrings/correto.gpg && \
echo "deb [signed-by=/usr/share/keyrings/corretto.gpg] https://apt.corretto.aws stable main" > /etc/apt/sources.list.d/corretto.list && \
curl -s https://apt.corretto.aws/corretto.key | gpg --dearmor -o /usr/share/keyrings/corretto.gpg && \
export NODE_VERSION="18.x" && \
export ARCH=$(dpkg --print-architecture) && \
echo "deb [arch=$ARCH signed-by=/usr/share/keyrings/nodesource.gpg] https://deb.nodesource.com/node_$NODE_VERSION nodistro main" > /etc/apt/sources.list.d/nodesource.list && \
Expand Down
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -237,7 +237,7 @@ wget: apt-get-wget
java:
@ # java has a different apt-get package name.
if [[ "$$(which java)" == "" ]]; then \
sudo apt-get install -qqy --no-install-suggests temurin-11-jdk; \
sudo apt-get install -qqy --no-install-suggests java-11-amazon-corretto-jdk; \
fi

gpg:
Expand Down

0 comments on commit 604b242

Please sign in to comment.