Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove rounding on interop test results totals cells #4145

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

DanielRyanSmith
Copy link
Contributor

Fixes #4107

This change removes totals percentage rounding up when aggregating the interop percentages on the test results page. The first fix landed for this still utilized rounding to the nearest tenth of one percent, which is not in line with the actual interop score aggregation, which does not implement any rounding up.

@DanielRyanSmith DanielRyanSmith requested review from KyleJu and removed request for KyleJu December 9, 2024 18:56
@DanielRyanSmith DanielRyanSmith marked this pull request as draft December 9, 2024 19:02
@DanielRyanSmith DanielRyanSmith marked this pull request as ready for review December 10, 2024 22:33
@DanielRyanSmith DanielRyanSmith merged commit af99fd3 into main Dec 10, 2024
12 checks passed
@DanielRyanSmith DanielRyanSmith deleted the remove-rounding-results branch December 10, 2024 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some Focus Area percentages on dashboard don't match the results percentage
2 participants