Rename serializable to shadowrootserializable #45142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-5375416
branch
from
d137998 to
b8ec9f0
Compare
See the conversation here: whatwg/html#10139 But the TL;DR is that the `<template>` attribute corresponding to the declarative shadow root `serializable` attribute should be named in a parallel way to other DSD-related attributes, meaning it should start with `shadowroot*`. Bug: 41490936 Change-Id: I40ea496c22147bac7dcdfb74cd7bf4a3abae8be9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5375416 Commit-Queue: Di Zhang <[email protected]> Reviewed-by: Di Zhang <[email protected]> Auto-Submit: Mason Freed <[email protected]> Cr-Commit-Position: refs/heads/main@{#1274374}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-5375416
branch
from
b8ec9f0 to
cf8e84c
Compare
wpt-pr-bot
approved these changes
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the conversation here:
whatwg/html#10139
But the TL;DR is that the
\<template>attribute correspondingto the declarative shadow root
serializableattribute shouldbe named in a parallel way to other DSD-related attributes,
meaning it should start with
shadowroot*.Bug: 41490936
Change-Id: I40ea496c22147bac7dcdfb74cd7bf4a3abae8be9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5375416
Commit-Queue: Di Zhang <[email protected]>
Reviewed-by: Di Zhang <[email protected]>
Auto-Submit: Mason Freed <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1274374}