WIP implement localized quotes #49835
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
wpt-pr-bot
approved these changes
Dec 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement quotes. Generate correct quote characters that matches the locale. It's done by enabling the
quotes.cssUA style sheet.Note: Quote depth calculation is not supported yet.
Problems: using a UA sheet for default quote characters doesn't seem like the right approach because:
autovalueThe above issues might be mitigated if we let the UA sheet set an internal property instead of the
quoteproperty directly. Nevertheless, it still matches every element and therefore may cause a performance hit.The proper approach seem to be adding quotes support to the icu crate. Should we do that instead?
Reviewed in servo/servo#34770