Get rid of remote_queue from browsers #49838
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This doesn't belong here, especially given it was only ever used to send "log" commands (which there's no need for: we're within the same process, we can just invoke the logger directly). While we're at it, migrate LogcatRunner over to using the same OutputHandler as used elsewhere (e.g., for WebDriver), thus hopefully avoiding further duplication.
wpt-pr-bot
added
infra
wptrunner
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This doesn't belong here, especially given it was only ever used to
send "log" commands (which there's no need for: we're within the same
process, we can just invoke the logger directly).
While we're at it, migrate LogcatRunner over to using the same
OutputHandler as used elsewhere (e.g., for WebDriver), thus hopefully
avoiding further duplication.