-
-
Notifications
You must be signed in to change notification settings - Fork 610
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: graceful exit terminal #3075
base: master
Are you sure you want to change the base?
Conversation
@alexander-akait should we add flag to enable this behavior as dev server does? |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3075 +/- ##
==========================================
- Coverage 91.50% 91.48% -0.03%
==========================================
Files 23 23
Lines 1719 1738 +19
Branches 519 524 +5
==========================================
+ Hits 1573 1590 +17
- Misses 146 148 +2
Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, let's add couple tests - just create custom plugin with infinity waiting and send SIGINT
signals to close it
/cc @alexander-akait |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you rebase?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No activity, closing.
@evenstensberg let's keep, it is a bug on our side |
What kind of change does this PR introduce?
feature
Did you add tests for your changes?
WIP
If relevant, did you update the documentation?
Summary
Added code for graceful exit.
For reference: https://github.com/webpack/webpack-dev-server/blob/75999bb9bb8803de633fcb037405f45a5bf7d029/lib/Server.js#L1808-L1838
Does this PR introduce a breaking change?
Yup can be for tools that consume webpack-cli's output.
Other information
/cc @alexander-akait