fix Card not re-render if state change on parent #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@webraptor Hi, i made some changes related to #85. can you please merge and release asap? thank you |
webraptor
requested changes
Nov 22, 2022
| @@ -68,7 +68,8 @@ class Swiper extends Component { | |||
| const { props, state } = this | |||
| const propsChanged = ( | |||
| !isEqual(props.cards, nextProps.cards) || | |||
| props.cardIndex !== nextProps.cardIndex | |||
| props.cardIndex !== nextProps.cardIndex || | |||
| props.renderCard !== nextProps.renderCard | |||
There was a problem hiding this comment.
@iyansr how does comparing the renderCard function help? I'm pretty sure it will not work or improve the swiper in any way, at least not without introducing a lot of other issues for other people.
|
@iyansr Thanks this code worked for me. I am using this deck swiper to render questions. and my requirement was, whenever the user tap on the card user should view their answer on the card, This could happen because of your code. I added your code in node_modules directly. |
|
glad it helps @hmdrx ! |
|
@webraptor seems like someone have similar problem :D |
|
Thank you and it works @iyansr |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #85