Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

beinc.py 4.4: add some minor fixes and code cleanup #557

Merged
merged 1 commit into from
Jul 8, 2024
Merged

beinc.py 4.4: add some minor fixes and code cleanup #557

merged 1 commit into from
Jul 8, 2024

Conversation

blackm0re
Copy link
Contributor

Script info

  • Script name: beinc.py
  • Version: 4.4
  • Requirements: 
  • Min WeeChat version: 0.4.0
  • Script tags: notify

Description

Upgrades to BEINC 4.4: https://github.com/blackm0re/BEINC/releases/tag/v4.4

Checklist (new script)

  • Single commit, single file added
  • Commit message: New script name.py: short description…
  • No similar script already exists
  • Name: max 32 chars, only lower case letters, digits and underscores
  • Unique name, does not already exist in repository
  • No shebang on the first line
  • Comment in script with name/pseudo, e-mail and license
  • Only English in code/comments
  • Pure WeeChat API used, no extra API
  • Function hook_process is used for any blocking call
  • For Python script: works with Python 3 (Python 2 support is optional)
  • Score 100 / 100 displayed by weechat-script-lint

Checklist (script update)

  • Author has been contacted
  • Single commit, single file added
  • Commit message format: script_name.py X.Y: …
  • Script version and Changelog have been updated
  • For Python script: works with Python 3 (Python 2 support is optional)
  • Score 100 / 100 displayed by weechat-script-lint

Checklist (script deletion)

  • Author has been contacted
  • Single commit, single file deleted
  • Commit message format: Remove script name.py with reasons in description

@flashcode flashcode merged commit 2bbe602 into weechat:master Jul 8, 2024
1 check passed
@flashcode flashcode self-assigned this Jul 8, 2024
@flashcode flashcode added the refactoring Code refactoring label Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@flashcode flashcode

Labels
refactoring Code refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@blackm0re @flashcode