feat: favor v in Signature.toHex (#35)

* BREAKING CHANGE: Use v when converting signatures to hex format * changeset * Update blue-flowers-applaud.md --------- Co-authored-by: jxom <[email protected]>
wevm · Dec 1, 2024 · 4680b06 · 4680b06
1 parent 15f9863
commit 4680b06
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 4 deletions.
diff --git a/.changeset/blue-flowers-applaud.md b/.changeset/blue-flowers-applaud.md
@@ -0,0 +1,5 @@
+---
+"ox": minor
+---
+
+Updated `Signature.toHex` to serialize the last byte as `v` instead of `yParity` for widened compatibility.
diff --git a/src/core/Signature.ts b/src/core/Signature.ts
@@ -527,7 +527,7 @@ export function toHex(signature: Signature<boolean>): Hex.Hex {
     Hex.fromNumber(s, { size: 32 }),
     // If the signature is recovered, add the recovery byte to the signature.
     typeof signature.yParity === 'number'
-      ? Hex.fromNumber(signature.yParity, { size: 1 })
+      ? Hex.fromNumber(yParityToV(signature.yParity), { size: 1 })
       : '0x',
   )
 

diff --git a/src/core/_test/Signature.test.ts b/src/core/_test/Signature.test.ts
@@ -444,7 +444,7 @@ describe('serialize', () => {
         yParity: 1,
       }),
     ).toMatchInlineSnapshot(
-      `"0x6e100a352ec6ad1b70802290e18aeed190704973570f3b8ed42cb9808e2ea6bf4a90a229a244495b41890987806fcbd2d5d23fc0dbe5f5256c2613c039d76db801"`,
+      `"0x6e100a352ec6ad1b70802290e18aeed190704973570f3b8ed42cb9808e2ea6bf4a90a229a244495b41890987806fcbd2d5d23fc0dbe5f5256c2613c039d76db81c"`,
     )
 
     expect(
@@ -454,7 +454,7 @@ describe('serialize', () => {
         yParity: 0,
       }),
     ).toMatchInlineSnapshot(
-      `"0x6e100a352ec6ad1b70802290e18aeed190704973570f3b8ed42cb9808e2ea6bf4a90a229a244495b41890987806fcbd2d5d23fc0dbe5f5256c2613c039d76db800"`,
+      `"0x6e100a352ec6ad1b70802290e18aeed190704973570f3b8ed42cb9808e2ea6bf4a90a229a244495b41890987806fcbd2d5d23fc0dbe5f5256c2613c039d76db81b"`,
     )
 
     expect(
@@ -543,7 +543,7 @@ describe('toBytes', () => {
       215,
       109,
       184,
-      1,
+      28,
     ]
   `,
     )