Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

honor the window_close_confirmation config option when quitting #4420

Merged
merged 1 commit into from
Dec 2, 2023
Merged

honor the window_close_confirmation config option when quitting #4420

merged 1 commit into from
Dec 2, 2023

Conversation

quantonganh
Copy link
Contributor

Fixes #4362

yerke
yerke approved these changes Nov 11, 2023
View reviewed changes
Copy link
Contributor

@yerke yerke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on my machine. Works great! Thanks!
@wez Can you please take a look at this PR?

@yerke yerke mentioned this pull request Nov 11, 2023
Closed
@megalithic
Copy link

just came to say THANK YOU for this PR!

@wez wez merged commit f2a9c06 into wez:main Dec 2, 2023
14 of 16 checks passed
@wez
Copy link
Owner

wez commented Dec 2, 2023

Looks good, thank you!

wez added a commit that referenced this pull request Dec 2, 2023
@wez
docs: changelog for #4420
ac23087
@devsunb devsunb mentioned this pull request Dec 5, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yerke yerke yerke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add configuration option to avoid "Terminate WezTerm?" pop up on macOS when OS wants to terminate it
4 participants
@quantonganh @megalithic @wez @yerke