Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make navigate() use UTF-8 in the URL parser #9756

Merged
merged 2 commits into from
Jul 25, 2024
Merged

Make navigate() use UTF-8 in the URL parser #9756

merged 2 commits into from
Jul 25, 2024

Conversation

annevk
Copy link
Member

@annevk annevk commented Sep 19, 2023 •
edited by pr-preview bot
Loading

Fixes #9708.

(See WHATWG Working Mode: Changes for more details.)

/nav-history-apis.html ( diff )

domenic
domenic approved these changes Sep 26, 2023
View reviewed changes
Copy link
Member

@domenic domenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. You can count Chromium as interested. I've filed https://bugs.chromium.org/p/chromium/issues/detail?id=1486748 .

You can either write WPTs yourself or wait for us to do so as part of the implementation.

source Show resolved Hide resolved
@domenic domenic added the needs tests Moving the issue forward requires someone to write tests label Sep 26, 2023
@annevk
Copy link
Member Author

annevk commented Sep 26, 2023

I'll fix that. Can we consider this a bug fix of the original PR given that only Chromium has implemented thus far or should I get Gecko to agree as well?

I suppose I'll copy @smaug---- and @zcorpan either way so they know.

@zcorpan
Copy link
Member

zcorpan commented Sep 26, 2023

Interest from Mozilla as well, thanks!

@annevk
Copy link
Member Author

annevk commented Sep 26, 2023

Happy to wait for tests. I'll assign this to @domenic to merge when the tests arrive in WPT.

@annevk
Copy link
Member Author

annevk commented Jul 15, 2024

@rwlbuis interested in taking on the tests?

@domenic domenic removed the needs tests Moving the issue forward requires someone to write tests label Jul 19, 2024
@domenic
Copy link
Member

domenic commented Jul 19, 2024

I got around to writing this change up for Chromium, including tests. Once my build passes and the tests export correctly, we can merge this.

chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Jul 24, 2024
@domenic @chromium-wpt-export-bot
Navigation API: always resolve URLs using UTF-8
b50c71d 
Follows whatwg/html#9756.

Fixed: 40283021
Change-Id: Iac654e94044fb97c4618599fee8ecedcd0efdb4d
@chromium-wpt-export-bot chromium-wpt-export-bot mentioned this pull request Jul 24, 2024
Merged
aarongable pushed a commit to chromium/chromium that referenced this pull request Jul 25, 2024
@domenic
Navigation API: always resolve URLs using UTF-8
836c959 
Follows whatwg/html#9756.

Fixed: 40283021
Change-Id: Iac654e94044fb97c4618599fee8ecedcd0efdb4d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5722413
Auto-Submit: Domenic Denicola <[email protected]>
Reviewed-by: Nate Chapin <[email protected]>
Commit-Queue: Nate Chapin <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1332686}
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Jul 25, 2024
@domenic @chromium-wpt-export-bot
Navigation API: always resolve URLs using UTF-8
fca628b 
Follows whatwg/html#9756.

Fixed: 40283021
Change-Id: Iac654e94044fb97c4618599fee8ecedcd0efdb4d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5722413
Auto-Submit: Domenic Denicola <[email protected]>
Reviewed-by: Nate Chapin <[email protected]>
Commit-Queue: Nate Chapin <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1332686}
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Jul 25, 2024
@domenic @chromium-wpt-export-bot
Navigation API: always resolve URLs using UTF-8
2f1700a 
Follows whatwg/html#9756.

Fixed: 40283021
Change-Id: Iac654e94044fb97c4618599fee8ecedcd0efdb4d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5722413
Auto-Submit: Domenic Denicola <[email protected]>
Reviewed-by: Nate Chapin <[email protected]>
Commit-Queue: Nate Chapin <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1332686}
@domenic domenic merged commit 4f3ac96 into main Jul 25, 2024
1 check passed
@domenic domenic deleted the annevk/navigate branch July 25, 2024 02:21
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Jul 26, 2024
@domenic @moz-wptsync-bot
Bug 1909763 [wpt PR 47284] - Navigation API: always resolve URLs usin…
8749756 
…g UTF-8, a=testonly

Automatic update from web-platform-tests
Navigation API: always resolve URLs using UTF-8

Follows whatwg/html#9756.

Fixed: 40283021
Change-Id: Iac654e94044fb97c4618599fee8ecedcd0efdb4d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5722413
Auto-Submit: Domenic Denicola <[email protected]>
Reviewed-by: Nate Chapin <[email protected]>
Commit-Queue: Nate Chapin <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1332686}

--

wpt-commits: 2f1700a56d0fefd1e68ba043e5b58ce64e31e27d
wpt-pr: 47284
i3roly pushed a commit to i3roly/firefox-dynasty that referenced this pull request Jul 26, 2024
@domenic @moz-wptsync-bot
Bug 1909763 [wpt PR 47284] - Navigation API: always resolve URLs usin…
ddb5391 
…g UTF-8, a=testonly

Automatic update from web-platform-tests
Navigation API: always resolve URLs using UTF-8

Follows whatwg/html#9756.

Fixed: 40283021
Change-Id: Iac654e94044fb97c4618599fee8ecedcd0efdb4d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5722413
Auto-Submit: Domenic Denicola <[email protected]>
Reviewed-by: Nate Chapin <[email protected]>
Commit-Queue: Nate Chapin <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1332686}

--

wpt-commits: 2f1700a56d0fefd1e68ba043e5b58ce64e31e27d
wpt-pr: 47284
ErichDonGubler pushed a commit to erichdongubler-mozilla/firefox that referenced this pull request Jul 27, 2024
@domenic @moz-wptsync-bot
Bug 1909763 [wpt PR 47284] - Navigation API: always resolve URLs usin…
70e1283 
…g UTF-8, a=testonly

Automatic update from web-platform-tests
Navigation API: always resolve URLs using UTF-8

Follows whatwg/html#9756.

Fixed: 40283021
Change-Id: Iac654e94044fb97c4618599fee8ecedcd0efdb4d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5722413
Auto-Submit: Domenic Denicola <[email protected]>
Reviewed-by: Nate Chapin <[email protected]>
Commit-Queue: Nate Chapin <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1332686}

--

wpt-commits: 2f1700a56d0fefd1e68ba043e5b58ce64e31e27d
wpt-pr: 47284
rwlbuis added a commit to rwlbuis/WebKit that referenced this pull request Aug 28, 2024
@rwlbuis
Navigation: always resolve URLs with UTF-8
6a949d3 
https://bugs.webkit.org/show_bug.cgi?id=276809

Reviewed by NOBODY (OOPS!).

Implement the spec change from whatwg/html#9756.

* LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-methods/navigate-relative-url-utf8.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-methods/navigate-relative-url-utf8_encoding=utf8-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-methods/navigate-relative-url-utf8_encoding=windows-1252-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-methods/navigate-relative-url-utf8_encoding=x-cp1251-expected.txt: Added.
* Source/WebCore/page/Navigation.cpp:
(WebCore::Navigation::navigate):
@rwlbuis rwlbuis mentioned this pull request Aug 28, 2024
Merged
webkit-commit-queue pushed a commit to rwlbuis/WebKit that referenced this pull request Aug 29, 2024
@rwlbuis
Navigation: always resolve URLs with UTF-8
4d43595 
https://bugs.webkit.org/show_bug.cgi?id=276809

Reviewed by Alex Christensen.

Implement the spec change from whatwg/html#9756.

* LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-methods/navigate-relative-url-utf8.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-methods/navigate-relative-url-utf8_encoding=utf8-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-methods/navigate-relative-url-utf8_encoding=windows-1252-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-methods/navigate-relative-url-utf8_encoding=x-cp1251-expected.txt: Added.
* Source/WebCore/page/Navigation.cpp:
(WebCore::Navigation::navigate):

Canonical link: https://commits.webkit.org/282889@main
webkit-commit-queue pushed a commit to rwlbuis/WebKit that referenced this pull request Aug 29, 2024
@rwlbuis
Navigation: always resolve URLs with UTF-8
3443b5d 
https://bugs.webkit.org/show_bug.cgi?id=276809

Reviewed by Alex Christensen.

Implement the spec change from whatwg/html#9756.

* LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-methods/navigate-relative-url-utf8.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-methods/navigate-relative-url-utf8_encoding=utf8-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-methods/navigate-relative-url-utf8_encoding=windows-1252-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-methods/navigate-relative-url-utf8_encoding=x-cp1251-expected.txt: Added.
* Source/WebCore/page/Navigation.cpp:
(WebCore::Navigation::navigate):

Canonical link: https://commits.webkit.org/282890@main
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@domenic domenic domenic approved these changes

Assignees

@domenic domenic

Labels
normative change topic: navigation
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

navigate() should not use parse a URL
3 participants
@annevk @zcorpan @domenic