Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relationship and surname from table_filters to surname_table #578

Draft
wants to merge 8 commits into
base: development
Choose a base branch
from

Conversation

FlominatorTM
Copy link
Contributor

@FlominatorTM FlominatorTM commented Jul 14, 2024

known issues so far

  • feature remove from watchlist has missing editlink
  • more button at surname tables stumbles upon birthYear null - can't reproduce
  • home icon throws some webpack error - file is not needed anymore anyway
  • suggestions only make sense on watchlist
  • suggestions are always shown, regardless of option (check missing at the moment)
  • retrieving activation status of table filters from surname tables doesn't work (function AddFilters)
  • hide columns when watchlist shows spage pages
  • show "changed later" or something in suggestions column if last edit was after suggestion date -> waiting for @shogenapps
  • show suggestions also for surname pages and searches -> waiting for Ales for a way to retrieve this query in rendered state via fetch (can also be released without)

@FlominatorTM FlominatorTM self-assigned this Jul 14, 2024
@FlominatorTM FlominatorTM requested a review from shogenapps July 14, 2024 10:11
}

if (wasTouchedAfterSuggestionDate) {
//magic to insert "changed later" in the suggestion column
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shogenapps: Please help me out with some jQuery magic here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants