Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WFCORE-7095] Deprecate ModuleDependency.getIdentifier() for removal #6282

Merged
merged 1 commit into from
Dec 23, 2024
Merged

[WFCORE-7095] Deprecate ModuleDependency.getIdentifier() for removal #6282

merged 1 commit into from
Dec 23, 2024

Conversation

bstansberry
Copy link
Contributor

@bstansberry bstansberry changed the title [WFCORE-7095] Deprecate ModuleDependency.getIdentifier() for removal; move partly away from MI in ServiceModuleLoaderWfcore 7095 [WFCORE-7095] Deprecate ModuleDependency.getIdentifier() for removal; move partly away from MI in ServiceModuleLoader Dec 15, 2024
@wildfly-ci

This comment was marked as off-topic.

Sign in to view
@bstansberry bstansberry added the hold Do not merge this PR label Dec 15, 2024
@bstansberry
Copy link
Contributor Author

bstansberry commented Dec 15, 2024 •
edited
Loading

I put the 'hold' label on this because in the joy of refactoring I forgot about #6247, which should take precedence for that piece of this. This is mostly about different things.

@bstansberry bstansberry removed the hold Do not merge this PR label Dec 18, 2024
@wildfly-ci
Copy link

Core -> Full Integration Build 14452 outcome was UNKNOWN using a merge of d1c4ec0
Summary: Canceled (Error while applying patch; cannot find commit 24c454c in the https://github.com/wildfly/wildfly-core.git repository, possible reason: refs/pull/6282/merge branch was updated and the commit selected for the ... Build time: 00:00:17

@wildfly-ci
Copy link

Core -> Full Integration Build 14150 outcome was UNKNOWN using a merge of d1c4ec0
Summary: Canceled (Error while applying patch; cannot find commit 24c454c in the https://github.com/wildfly/wildfly-core.git repository, possible reason: refs/pull/6282/merge branch was updated and the commit selected for the ... Build time: 00:00:17

@wildfly-ci
Copy link

Core -> WildFly Preview Integration Build 14233 outcome was UNKNOWN using a merge of d1c4ec0
Summary: Canceled (Error while applying patch; cannot find commit 24c454c in the https://github.com/wildfly/wildfly-core.git repository, possible reason: refs/pull/6282/merge branch was updated and the commit selected for the ... Build time: 00:00:17

bstansberry
bstansberry commented Dec 20, 2024
View reviewed changes
server/src/main/java/org/jboss/as/server/deployment/module/ModuleDependency.java
@@ -11,6 +11,7 @@
import java.util.Objects;
import java.util.Optional;

import org.jboss.as.controller.ModuleIdentifierUtil;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: uses of canonicalModuleIdentifier in this class are a kind of second line of defense I plan to remove once I'm confident we've correctly handled canonicalization in the code that directly handles external input of module names.

@bstansberry bstansberry changed the title [WFCORE-7095] Deprecate ModuleDependency.getIdentifier() for removal; move partly away from MI in ServiceModuleLoader [WFCORE-7095] Deprecate ModuleDependency.getIdentifier() for removal Dec 20, 2024
@bstansberry bstansberry removed the 28.x label Dec 20, 2024
@wildfly-ci

This comment was marked as off-topic.

Sign in to view
@bstansberry bstansberry mentioned this pull request Dec 22, 2024
Merged
@yersan yersan added the ready-for-merge This PR is ready to be merged and fulfills all requirements label Dec 23, 2024
@yersan yersan merged commit e5775f4 into wildfly:main Dec 23, 2024
12 of 13 checks passed
@bstansberry bstansberry deleted the WFCORE-7095 branch January 2, 2025 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yersan yersan yersan approved these changes

Assignees
No one assigned
Labels
ready-for-merge This PR is ready to be merged and fulfills all requirements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bstansberry @wildfly-ci @yersan