Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Astro 5.1 blog #1355

Merged
merged 11 commits into from
Dec 19, 2024
Merged

Add Astro 5.1 blog #1355

merged 11 commits into from
Dec 19, 2024
+151 −0

Conversation

ascorbic
Copy link
Contributor

Adds a blog post for the Astro 5.1 release

Browser Test Checklist

I have tested this PR on at least three of the following browsers:

  • Chrome / Chromium
  • Firefox
  • Android Firefox
  • Safari
  • iOS Safari

@netlify Netlify
Copy link

netlify bot commented Dec 17, 2024 •
edited
Loading

✅ Deploy Preview for astro-www-2 ready!

Name Link
🔨 Latest commit 1039b4b
🔍 Latest deploy log https://app.netlify.com/sites/astro-www-2/deploys/6762bc0be3a0f10008a51a29
😎 Deploy Preview https://deploy-preview-1355--astro-www-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 5 paths audited
Performance: 99 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 94 (🟢 up 4 from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

ematipico
ematipico reviewed Dec 17, 2024
View reviewed changes
src/content/blog/astro-510.mdx Outdated Show resolved Hide resolved
src/content/blog/astro-510.mdx Show resolved Hide resolved
src/content/blog/astro-510.mdx Outdated Show resolved Hide resolved
sarah11918
sarah11918 reviewed Dec 17, 2024
View reviewed changes
Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Learning my lesson, here is the Sessions docs review only!

src/content/blog/astro-510.mdx Outdated Show resolved Hide resolved
src/content/blog/astro-510.mdx Outdated Show resolved Hide resolved
src/content/blog/astro-510.mdx Outdated Show resolved Hide resolved
src/content/blog/astro-510.mdx Outdated Show resolved Hide resolved
sarah11918
sarah11918 reviewed Dec 17, 2024
View reviewed changes
Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image caching review!

src/content/blog/astro-510.mdx Outdated Show resolved Hide resolved
src/content/blog/astro-510.mdx Outdated Show resolved Hide resolved
@ascorbic @sarah11918
Apply suggestions from code review
009d32c 
Co-authored-by: Sarah Rainsberger <[email protected]>
sarah11918
sarah11918 reviewed Dec 17, 2024
View reviewed changes
Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

getActionPath() review!

src/content/blog/astro-510.mdx Outdated Show resolved Hide resolved
src/content/blog/astro-510.mdx Outdated Show resolved Hide resolved
src/content/blog/astro-510.mdx Outdated Show resolved Hide resolved
@ascorbic @sarah11918
Apply suggestions from code review
fad3a14 
Co-authored-by: Sarah Rainsberger <[email protected]>
yanthomasdev
yanthomasdev reviewed Dec 17, 2024
View reviewed changes
Copy link
Member

@yanthomasdev yanthomasdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few small nits, overall looks great!

src/content/blog/astro-510.mdx Outdated Show resolved Hide resolved
src/content/blog/astro-510.mdx Outdated Show resolved Hide resolved
src/content/blog/astro-510.mdx Outdated Show resolved Hide resolved
src/content/blog/astro-510.mdx Outdated Show resolved Hide resolved
src/content/blog/astro-510.mdx Show resolved Hide resolved
@ascorbic @yanthomasdev @sarah11918
Apply suggestions from code review
332a79e 
Co-authored-by: Yan <[email protected]>
Co-authored-by: Sarah Rainsberger <[email protected]>
@ascorbic @sarah11918
Add code highlight
330673d 
Co-authored-by: Sarah Rainsberger <[email protected]>
sarah11918
sarah11918 approved these changes Dec 19, 2024
View reviewed changes
Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay! Go team! 🥳

@ematipico ematipico merged commit 12baba6 into main Dec 19, 2024
6 checks passed
@ematipico ematipico deleted the feat/astro-510 branch December 19, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yanthomasdev yanthomasdev yanthomasdev left review comments

@ematipico ematipico ematipico left review comments

@sarah11918 sarah11918 sarah11918 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ascorbic @ematipico @sarah11918 @yanthomasdev @florian-lefebvre