Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Astro 3.2 article #833

Merged
merged 13 commits into from
Sep 28, 2023
Merged

Astro 3.2 article #833

merged 13 commits into from
Sep 28, 2023

Conversation

matthewp
Copy link
Contributor

No description provided.

@vercel
Copy link

vercel bot commented Sep 27, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
astro-build ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 28, 2023 6:28pm

sarah11918
sarah11918 reviewed Sep 27, 2023
View reviewed changes
Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @matthewp and @martrapp !!

Just tweaked a little phrasing to show you examples of how it could sound a little more bloggy, so see if that gives you any inspiration!

src/content/blog/astro-320.mdx Outdated Show resolved Hide resolved
src/content/blog/astro-320.mdx Outdated Show resolved Hide resolved
src/content/blog/astro-320.mdx Outdated Show resolved Hide resolved
src/content/blog/astro-320.mdx Outdated Show resolved Hide resolved
yanthomasdev
yanthomasdev reviewed Sep 27, 2023
View reviewed changes
Copy link
Member

@yanthomasdev yanthomasdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @matthewp, added a few small comments 🙌

src/content/blog/astro-320.mdx Outdated Show resolved Hide resolved
src/content/blog/astro-320.mdx Outdated Show resolved Hide resolved
src/content/blog/astro-320.mdx Outdated Show resolved Hide resolved
src/content/blog/astro-320.mdx Outdated Show resolved Hide resolved
sarah11918
sarah11918 approved these changes Sep 28, 2023
View reviewed changes
Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @matthewp ! 🙌

delucis
delucis approved these changes Sep 28, 2023
View reviewed changes
Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

yanthomasdev
yanthomasdev reviewed Sep 28, 2023
View reviewed changes
Copy link
Member

@yanthomasdev yanthomasdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small final nit, after this one LGTM!

src/content/blog/astro-320.mdx Outdated Show resolved Hide resolved
FredKSchott
FredKSchott approved these changes Sep 28, 2023
View reviewed changes
src/content/blog/astro-320.mdx Outdated Show resolved Hide resolved
@matthewp matthewp merged commit 523a9c7 into main Sep 28, 2023
@matthewp matthewp deleted the astro-three-dot-two branch September 28, 2023 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yanthomasdev yanthomasdev yanthomasdev left review comments

@sarah11918 sarah11918 sarah11918 approved these changes

@FredKSchott FredKSchott FredKSchott approved these changes

@delucis delucis delucis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@matthewp @delucis @FredKSchott @sarah11918 @yanthomasdev