Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unexpected details marker on Safari #73

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

bholmesdev
Copy link
Contributor

image

Removes the unexpected details marker on Safari. display: flex seems to remove this on other browsers, but Safari needs an explicit style.

Copy link

netlify bot commented Nov 8, 2024

Deploy Preview for astro-new ready!

Name Link
🔨 Latest commit bea1c86
🔍 Latest deploy log https://app.netlify.com/sites/astro-new/deploys/672e0c1179a3d30008a2d717
😎 Deploy Preview https://deploy-preview-73--astro-new.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A <style> tag?! No utility class?! 😱

LGTM! Thanks @bholmesdev — I tested in Safari 18.1 and this fixes it for me too ✅

@bholmesdev
Copy link
Contributor Author

@delucis sometimes you just gotta feel something ✨

@bholmesdev bholmesdev merged commit 8e35d7e into main Nov 8, 2024
5 checks passed
@bholmesdev bholmesdev deleted the fix-details-marker-safari branch November 8, 2024 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants