-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add copy CLI command buttons to templates #75
Conversation
✅ Deploy Preview for astro-new ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for me @delucis ! I tried the copy button on a handful of the repos, including some of the other tabs, and the command worked every time for me! 💪
Won't have time to make a full suggestion before T&D, but wanted to mention that the announcement is not great at the moment, e.g. this demo using VoiceOver with a duplicated label and the useless image. demo.mp4 |
Thank you! Was different for me when testing with VoiceOver in Chrome, but I did change some small details since then, so maybe it changed. |
OK, at least added Other icon usage on the site needs this too, but I see a few other a11y issues like that, so will tackle that in a separate PR. Edit: #77 addresses many accessibility issues, including icons in the accessibility tree. |
This PR adds a “Copy CLI command” button to each template on astro.new to make it easier to run
create astro
for a specific template (instead of opening in a web IDE).Closes #70
Closes DX-1474
Looks like this:
(The first relevant commit is f19fb40 — the others are still left over from #74)
Tested in Chrome, Firefox & Safari on macOS, and Firefox Android.