Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(astro): code refactor #11343

Merged
merged 13 commits into from
Jul 17, 2024
Merged

refactor(astro): code refactor #11343

merged 13 commits into from
Jul 17, 2024

Conversation

Simon-He95
Copy link
Contributor

@Simon-He95 Simon-He95 commented Jun 26, 2024

Changes

refactor: reduce some additional conditional judgments

Testing

Docs

Copy link

changeset-bot bot commented Jun 26, 2024

⚠️ No Changeset found

Latest commit: ddd0f84

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Jun 26, 2024
@ematipico
Copy link
Member

@Simon-He95 I will move this PR to draft, until you fix the CI and provide correct description.

@ematipico ematipico marked this pull request as draft June 27, 2024 10:09
@Simon-He95 Simon-He95 marked this pull request as ready for review June 27, 2024 15:32
@Simon-He95
Copy link
Contributor Author

@ematipico, Can you help me review?

@ematipico
Copy link
Member

@Simon-He95, please fill out the template and explain your refactors.

@Simon-He95
Copy link
Contributor Author

@Simon-He95, please fill out the template and explain your refactors.

Refactoring basically reduces extra conditional judgments, because the two conditions are conflicting. I matched A, but it will still be judged once by B's if condition. This refactoring is to solve this problem.

@ematipico
Copy link
Member

I was mainly asking to update the PR description (template) :)

@Simon-He95
Copy link
Contributor Author

I was mainly asking to update the PR description (template) :)

ah, ok :)

@ematipico ematipico requested a review from bluwy July 17, 2024 13:00
@bluwy bluwy merged commit 6e459f0 into withastro:main Jul 17, 2024
13 checks passed
ematipico pushed a commit that referenced this pull request Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants