-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(astro): code refactor #11343
Conversation
|
@Simon-He95 I will move this PR to draft, until you fix the CI and provide correct description. |
@ematipico, Can you help me review? |
@Simon-He95, please fill out the template and explain your refactors. |
Refactoring basically reduces extra conditional judgments, because the two conditions are conflicting. I matched A, but it will still be judged once by B's if condition. This refactoring is to solve this problem. |
I was mainly asking to update the PR description (template) :) |
ah, ok :) |
Changes
refactor: reduce some additional conditional judgments
Testing
Docs