Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(next): remove CCC #12081

Merged
merged 9 commits into from
Sep 30, 2024
Merged

feat(next): remove CCC #12081

merged 9 commits into from
Sep 30, 2024

Conversation

florian-lefebvre
Copy link
Member

@florian-lefebvre florian-lefebvre commented Sep 26, 2024

Changes

  • Closes PLT-2551

Testing

Should still pass

Docs

withastro/docs#9507

Copy link

changeset-bot bot commented Sep 26, 2024

🦋 Changeset detected

Latest commit: 8217f9c

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added pkg: astro Related to the core `astro` package (scope) docs pr semver: minor Change triggers a `minor` release labels Sep 26, 2024
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is blocked because it contains a minor changeset. A reviewer will merge this at the next release if approved.

@florian-lefebvre

This comment has been minimized.

Copy link
Member

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RIP. Code changes all look good to me!

.changeset/wise-carrots-float.md Show resolved Hide resolved
.changeset/wise-carrots-float.md Outdated Show resolved Hide resolved
Copy link
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

internals.cacheManifestUsed and internals.cachedClientEntries can also be removed.

Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs PR is perfect, @florian-lefebvre ! I'd just make a suggestion to the changeset as below, then this is great! Thank you!

@florian-lefebvre florian-lefebvre merged commit 8679954 into next Sep 30, 2024
14 checks passed
@florian-lefebvre florian-lefebvre deleted the feat/next-remove-ccc branch September 30, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs pr pkg: astro Related to the core `astro` package (scope) semver: minor Change triggers a `minor` release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The collection "blog" does not exist or is empty with contentCollectionCache enabled under astro 5 beta.
5 participants